Pranav Joshi
Pranav Joshi
@fingolfin could you please review this PR ? This is the same algorithm that you reviewed in [the PR](https://github.com/sagemath/sage/pull/37481) to SageMath.
> I have some small comments, but I'd say the BIG missing thing is tests, lots of tests! > > As a suggestion, you could base you tests on something...
> I don't think this test ever executes the code from line 76 onwards Yes, the first time that block runs is for `SmallGroup(120,34)`, which I have added now.
Any other changes that I should make ?
I added a paragraph in documentation for `MinimalGeneratingSet` which mentions it as another option.
Could someone please review this ?
@fingolfin , I am working on a similar function for semi simple groups, which will be using this function. I'm quite new to GAP and open source in general and...
Should I document `MinimalFaithfulPermutationDegreeOfSimpleGroupWithIsomorphismType` or let it be, considering it isn't very user friendly. I am mainly using it for testing, since computing `IsomorphismTypeInfoFiniteSimpleGroup` takes some time.
> This should be integrated with the existing functiinality of `SufficientlySmallDegreeSimpleGroupOrder` (grp/simple.gi), which already provides much of this information up to order 2^55 Doesn't that function return a heuristic though?...
> > > This should be integrated with the existing functiinality of `SufficientlySmallDegreeSimpleGroupOrder` (grp/simple.gi), which already provides much of this information up to order 2^55 > > > > >...