Pramod Kumbhar
Pramod Kumbhar
> I guess we should modify the parser to strip spaces around name, right? I believe so! I don't this is where "spaces" as a name make sense.
> @alkino : If this is a good change, I wonder if similar change should be done on neuron side What do you think @alkino ? Can you check if...
@Helveg : thanks! Definitely revisit them. Some of the MOD files can be made compatible with some changes but I also wanted to make NMODL to handle all legacy usage...
Just for info : `create_statement` is often used for setting new statement in the ast. In the current implementation all AST nodes accept shared_ptr (in setter methods) and hence the...
> I understand that @pramodk find it more convenient that create_statement returns a std::shared_ptr What's your opinion on this @alkino ? I have no preference - if you think its...
cc: @alkino (see above)
WIP branch I created for this is [pramodk/nmodl-parser-tracing](https://github.com/BlueBrain/nmodl/tree/pramodk/nmodl-parser-tracing). Here are the rules from [nmodl.yy](https://github.com/BlueBrain/nmodl/blob/master/src/parser/nmodl.yy) that are not used in ModelDB models: ```bison | all MODEL_LEVEL INTEGER_PTR declare | step_block |...
Hello Michael, Yes, thats true. We didn't handle deallocation properly. Will address that soon. One of our thought was to turn generated `.cpp` code into full C++ class. This way...
I think this may not be only place where Name and VarName are used interchangeably. We can take a look next week.
> By the way, this doesn't happen with newer sympy versions like >= 1.9. @cattabiani : that's correct, right? I mentioned that this does **not** happen with the newer version...