Fix #8 (endly)

Jun 15 '22 17:06 alkino

I got only one problem (_) is not considered as an empty name, because the name is _.

Here _ means space.

I guess we should modify the parser to strip spaces around name, right?

Jun 15 '22 17:06 alkino

Logfiles from GitLab pipeline #60936 (:white_check_mark:) have been uploaded here!

Status and direct links:

Jun 16 '22 10:06 bbpbuildbot

@alkino : If this is a good change, I wonder if similar change should be done on neuron side. This way, we won't have situation where neuron will accept the mod file but coreneuron will fail to compile 🤔

Jun 16 '22 10:06 pramodk

I guess we should modify the parser to strip spaces around name, right?

I believe so! I don't this is where "spaces" as a name make sense.

Jun 17 '22 12:06 pramodk

@alkino : If this is a good change, I wonder if similar change should be done on neuron side

What do you think @alkino ? Can you check if NEURON accepts mod file containing empty unit name?

Jun 23 '22 13:06 pramodk

Codecov Report

Merging #883 (d5853f6) into master (0481f30) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #883      +/-   ##
==========================================
+ Coverage   68.74%   68.76%   +0.02%     
==========================================
  Files         189      189              
  Lines       25789    25808      +19     
==========================================
+ Hits        17729    17748      +19     
  Misses       8060     8060

Impacted Files	Coverage Δ
src/visitors/semantic_analysis_visitor.hpp	`100.00% <ø> (ø)`
src/visitors/semantic_analysis_visitor.cpp	`90.36% <100.00%> (+0.61%)`	:arrow_up:
test/unit/visitor/semantic_analysis.cpp	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Feb 13 '23 13:02 codecov[bot]

Logfiles from GitLab pipeline #101693 (:white_check_mark:) have been uploaded here!

Status and direct links:

Feb 13 '23 14:02 bbpbuildbot

Logfiles from GitLab pipeline #101806 (:white_check_mark:) have been uploaded here!

Status and direct links:

Feb 13 '23 16:02 bbpbuildbot

Logfiles from GitLab pipeline #102310 (:white_check_mark:) have been uploaded here!

Status and direct links:

Feb 15 '23 08:02 bbpbuildbot

Check unit empty

Codecov Report