Pramod Immaneni

Results 8 comments of Pramod Immaneni

Is it possible to come up with a unit test for this. Looks like the NPE happens only in some cases.

There are checkstyle errors, please see [ERROR] src/main/java/org/apache/apex/malhar/lib/wal/FSWindowDataManager.java:[487,11] (whitespace) WhitespaceAround: WhitespaceAround: 'if' is not followed by whitespace. [ERROR] src/main/java/org/apache/apex/malhar/lib/wal/FSWindowDataManager.java:[488] (indentation) Indentation: 'reader' have incorrect indentation level 11, expected level should...

@patilvikram can you respond to @vrozov comments

@tweise to your comment, in this case unfortunately individual contributions weren't clearly kept track of and hence the single commit. I don't think contributor stats should be the reason to...

Went through one more round of refactoring and changes.

There are some binary files checked in, example py4j-0.10.4.jar, py4j-0.10.4-src.zip, py4j-0.10.4.tar.gz. Are these needed?