Pradyot Ranjan comments

Results 149 comments of


                                            Pradyot Ranjan

Implemented `non_linear_time`, an array of time as an input to `step` function

> Thanks for taking this on. I don't think it is necessary to have both `npts` and `non_linear_time`. Instead, I think we should deprecate `npts`, require users to pass `dt`...

Implemented `non_linear_time`, an array of time as an input to `step` function

Should I change name of variable `non_linear_time` to something more accurate or is it ok? Also how to handle logic when function has both `dt` and `non_linear_time` as input? Should...

Implemented `non_linear_time`, an array of time as an input to `step` function

Now the output of ```py while time < end_time: step_solution = step_solver.step(step_solution, model, dt=500, non_linear_time=[0, 50, 100, 200, 500]) time += dt ``` Looks like:

Implemented `non_linear_time`, an array of time as an input to `step` function

Should we also remove `npts` from [here](https://github.com/pybamm-team/PyBaMM/blob/ee64eafc7f945fb6684ce22a60169f97f5a0f235/pybamm/simulation.py#L965) ? @rtimms @tinosulzer

Implemented `non_linear_time`, an array of time as an input to `step` function

I've also added tests.

Implemented `non_linear_time`, an array of time as an input to `step` function

I've made the changes! Please have a look.

Implemented `non_linear_time`, an array of time as an input to `step` function

@agriyakhetarpal why is [this](https://github.com/pybamm-team/PyBaMM/actions/runs/8003981310/job/21860421881?pr=3627) CI job failing?

Switch to an active citations parser dependency to replace `pybtex`

Can you suggest some useful resources that might help. Also if no one is already working on this I would love to !

Switch to an active citations parser dependency to replace `pybtex`

Thanks a lot for the detailed info! This would really be helpful

Switch to an active citations parser dependency to replace `pybtex`

Can you please explain why do we use citations and how does it help? For example :[here](https://github.com/pybamm-team/PyBaMM/blob/cf2203c618d6f86209f34d63a0efe10a540545fa/pybamm/models/submodels/particle_mechanics/swelling_only.py#L30). Also how does it register a citation above?