Pradyot Ranjan comments

Results 149 comments of


                                            Pradyot Ranjan

Removing `run-tests.py` file.

> @prady0t Is your branch still having problems? Do you need help fixing the branch? I can work with this, although I made a lot of commits.

Removing `run-tests.py` file.

> @prady0t, could you fix the failure in the style jobs so that the tests can run? Done. I removed lot of code lines from `conftest.py` file and now we...

Removing false flagging of assert statements from tests.

Let me add it back.

Removing false flagging of assert statements from tests.

Let me add tests

Removing false flagging of assert statements from tests.

Thanks @kratman

Use `hypothesis` to implement property based testing.

Sure! Please go ahead. Let us know if you need any help. I'll try to find out some tests where hypothesis can be used, it will help you get started....

Use `hypothesis` to implement property based testing.

Hi @RohitP2005, sorry for the late response. Yes you can start by looking into unit tests first. Here's a file where you can start https://github.com/pybamm-team/PyBaMM/blob/a1f73b6780187e9635c0c4a1164531cbf73fe70c/tests/unit/test_expression_tree/test_averages.py#L11 This file has tests to...

Use `hypothesis` to implement property based testing.

Before opening a tracking issue I would suggest going through the above mentioned tests and opening a PR covering both files first. We do not want to flood maintainers with...

Use `hypothesis` to implement property based testing.

@RohitP2005 I think we should first make a list of tests that can benefit most from this and will make sense to run in CI jobs given the extra time...