Pradeep Kumar

Is there a good reason why `Mapping.__contains__` expects `object`, but `Mapping.get` expects a strict type?

2

I ran into a case where a user intended to check whether an enum value `x` was present in a dictionary `Dict[int, int]`: `x.value in d`. But instead they wrote...

Avoid failing to trace a call when passed _Protocol or Generic

1

`Type[foo]` raises a `TypeError` when `foo` is `Generic` or `typing._Protocol`. Here's a repro: ``` # Source file. def try_protocol(): return SupportsInt.__mro__[1] $ monkeytype -v stub ... Failed collecting trace Traceback...

The reference to the `locals()` dictionary is updated when running from a script but not when running from MonkeyType. Repro: ``` # Source file. class Foo: def use_locals(self): locals_dictionary =...

# 🚀 Feature Add shape type stubs for Tensor functions. Annotate some of the xformers code with shape types so that future users can add new ones easily. Set up...

The comment referred to `as save_stdout` but the sample code used `as orig_stdout`. I'm guessing the comment hadn't been updated. So, I updated the comment.