Marco Pracucci
Marco Pracucci
I propose to deprecate `-ingester.ring.readiness-check-ring-health`. It defaults to `false` and we're not using it in jsonnet or Helm. Nowadays that ingesters requires persistency and so are deployed in K8S as...
Cortex interchangeably uses the terms "tenant", "org", "user" and their derived forms "tenant ID", "org ID", "user ID" . This generates quite a lot of confusion to newcomers and I...
#### What this PR does Currently, the logic around the last consumed offset which is committed to the Kafka consumer group is a bit convoluted: we don't commit the last...
#### What this PR does Updating dskit to get https://github.com/grafana/dskit/pull/509. #### Which issue(s) this PR fixes or relates to N/A #### Checklist - [ ] Tests updated. - [ ]...
Reduce memory allocations in functions used to propagate contextual information between gRPC calls
#### What this PR does In Mimir ingesters, 10% of object (and memory) allocations come from gRPC `metadata.FromIncomingContext()`. `metadata.FromIncomingContext()` is called in few places. The problem of `metadata.FromIncomingContext()` is that...
#### What this PR does Jsonnet and Helm `terminationGracePeriodSeconds` are unaligned. In this PR I'm proposing to align them, so that assert on differences between the two and easily spot...
#### What this PR does While working on https://github.com/grafana/mimir/pull/7529, I've noticed that we have utilities to add "source IP" in the gRPC metadata but we never read it (I've also...
The jsonnet definitions for compactor and store-gateway are buried into https://github.com/grafana/cortex-jsonnet/blob/master/cortex/tsdb.libsonnet. We should move them to dedicated files, like any other component.
We use a custom transport for memberlist, based on TCP protocol. The main reason why we use TCP is being able to transfer messages which are bigger than the maximum...
_This proposal is based on a theory I have, but haven't proved if it can significantly improve the messages propagation yet._ The dskit's memberlist client propagate changes (e.g. hash ring...