cortex-jsonnet icon indicating copy to clipboard operation
cortex-jsonnet copied to clipboard

Move compactor and store-gateway to dedicated files

Open pracucci opened this issue 5 years ago • 3 comments

The jsonnet definitions for compactor and store-gateway are buried into https://github.com/grafana/cortex-jsonnet/blob/master/cortex/tsdb.libsonnet. We should move them to dedicated files, like any other component.

pracucci avatar Oct 05 '20 07:10 pracucci

How is tsdb.libsonnet connected to the rest of this thing? It doesn't seem to be imported anywhere.

bboreham avatar Dec 14 '20 18:12 bboreham

We import it manually in clusters that use blocks engine. Clusters that don't use it don't import this file.

pstibrany avatar Dec 14 '20 18:12 pstibrany

We import it manually in clusters that use blocks engine. Clusters that don't use it don't import this file.

This tidbit would be fantastic to have in the readme or even just as a commented out line in the example manifest!
Especially with chunks storage being deprecated and blocks being the preferred default nowadays

hamishforbes avatar Jun 10 '21 21:06 hamishforbes