prabhu

Results 91 comments of prabhu

This is breaking scan release as well - https://github.com/ShiftLeftSecurity/sast-scan/runs/1382408660?check_suite_focus=true . Github status keeps showing green. Anyone available to take a look?

Yes the code is directly firing the idle event when blurred. Below is a workaround that will give you some mileage. ``` javascript var idleInfo = ifvisible.getIdleInfo(); if (!idleInfo.isIdle) {...

Please take time with your fix. Ideally we would like to review the fix if possible since I feel this library is quite flaky as it is.

This particular issue is causing an headache for many users. For nexus, the settings suggest here works https://github.com/jitpack/jitpack.io/issues/506#issuecomment-267338823

@rubenandre any idea what the 1 suppressed issue was? Could you investigate by running credscan directly?

@rubenandre this is going to require some testing. I think scan is looking for a minimum of 10 characters, where as your password is only 9 characters. https://github.com/ShiftLeftSecurity/sast-scan/blob/master/tools_config/credscan-config.toml#L177 Could you...

docker for desktop doesn't seem to be ready.

Example: ```json "originalUriBaseIds": { "PROJECTROOT": { "uri": "file://build.example.com/work/" }, "SRCROOT": { "uri": " src/", "uriBaseId": "PROJECTROOT" }, "BINROOT": { "uri": " bin/", "uriBaseId": "PROJECTROOT" } } ```

I think we should revisit this style of overriding config and see if there is a better approach out there.