Paul Querna comments

Results 35 comments of


                                            Paul Querna

Support for Vary header

This would be a great pull request, and I like how the proposal is split into 3 separate isolated changes. I assume for #1 you would use the normalization function...

Making the reasons a string would make for more readable logs

I agree. this could be a good change. is there a way to do this without breaking semver?

Format Cache-Control header

I think this would generally be a good feature - two quick thoughts: we might need a new structure to properly serialize it, and we might want to emit other...

I think basic support could be done today using the low level api, eg by populating `Object.RespDirectives` with the parsed results of `ParseResponseCacheControl(respHeaders.Get("Surrogate-Control"))`: https://godoc.org/github.com/pquerna/cachecontrol/cacheobject#Object Having said that, adding a field...

Consider adding strict parsing as an option

Do you think "errors" should be treated as a reason for non-cachability? eg, extend https://godoc.org/github.com/pquerna/cachecontrol/cacheobject#Reason ReasonErrQuoteMismatch. Otherwise I think the main APIs would need to be revised to have a...

pass escapeHTML flag through generated code

This is great, thank you! My only concern is changing the `marshalerFaster` interface. I don't have an alternative though.

Fix named slices

Can you add a test case for this?

map[string]*json.RawMessage fails

I think this is an issue because RawMessage is a type alias to []byte.... `type RawMessage []byte`

Panic runtime.error

@semihalev Can you share the structure this is happening with?

Decoder: Null accepted for non-nullable types

yes, this is a bug.