Quentin Pradet

I have been thinking about this quite a lot because it could help with the design of the async support and using `body` when adding support for Elasticsearch 8 was...

Hello, and thank you! We'll also need to add this to the sync version and add tests in `test_helpers`. cla/check

Hey @dhirschfeld! Long time no see. As a past Trio maintainer, I would love to see trio support! We only have a few mentions of `asyncio` in the elasticsearch-py and...

@dhirschfeld Trio support just landed in version 9.2 of the client! Note that it does not support node sniffing which uses a background task.

I had missed https://github.com/urllib3/urllib3/pull/3715! My version is more comprehensive, but it currently fails due to a dependency conflict. Dropping 3.9 will fix it.

I fully agree with your great review, @illia-v, but I haven't had time to fix my PR yet, sorry.

While tests pass now, coverage is failing because those two lines are no longer covered: * https://github.com/urllib3/urllib3/blob/816fcf04528bc0f89672e13398eb813dcc892490/src/urllib3/response.py#L739 * https://github.com/urllib3/urllib3/blob/816fcf04528bc0f89672e13398eb813dcc892490/src/urllib3/contrib/socks.py#L144-L147 They look like defensive code. Should I just add `Defensive:`?

Hello @Woiea, and thanks for your report. We're going to need more information to help you. * What are you trying to do? Did you use to have working code?...

The elasticsearch-py package in `/data/usr/tools/miniconda/envs/pytorch/lib/python3.10/site-packages/elasticsearch/` is not version 8.14.0. With 8.14.0, import `RequestsHttpConnection` should fail, while import `ApiError` from exceptions should work: ```python >>> from elasticsearch import Elasticsearch, RequestsHttpConnection Traceback...

Thanks for the approval! To be clear I am not planning to merge this, it just gives me useful information to restrict the permissions.