Quentin Pradet

Results 422 comments of Quentin Pradet

Oh, when you mentioned nested I assumed you meant the nested data type: https://www.elastic.co/guide/en/elasticsearch/reference/current/nested.html. Sorry for the misleading response. I will try to take a look later taking this new...

> I thought that the period and structure of the record meant that entryNumber is nested under _common. However, does the fact that the above code worked imply that is...

Thanks, you're right that it's a serious gap in the docs.

Done in https://github.com/elastic/elasticsearch-py/pull/2798

@4lissonsilveira Hello! Setting `verify_certs` to `False` would break cases where we specify an SSLContext and actually want to verify the certificates. Anyway, the logic should live in elastic-transport-python (this is...

buildkite test this please

@miguelgrinberg In my experience running pyupgrade and making various code changes as part of dropping a Python version is pretty common. For example, in urllib3: * https://github.com/urllib3/urllib3/pull/1429 * https://github.com/urllib3/urllib3/pull/2044 *...

Ah right! When I drop a version, I update `python_requires`, so anyone still using Python 3.7 will be stuck on 8.14. And it's the best moment to drop all the...

Hey @mpaluch92, thank you for your detailed bug report. You are right that passing a list of string is supported and that the type annotation is wrong. In fact, this...