Quentin Pradet

Results 343 comments of Quentin Pradet
trafficstars

Thanks. Would you mind pasting here a JSON response from Elasticsearch where _source is a list and fields is set? That would help reviewing this.

Thanks. Would you mind pasting here a JSON response from Elasticsearch where _source is a list and fields is set?

The API calls should definitely be in the [vectorstore helpers in the client](https://github.com/elastic/elasticsearch-py/tree/main/elasticsearch/helpers/vectorstore). That will directly improve snippets like https://www.elastic.co/search-labs/tutorials/search-tutorial/semantic-search/elser-model#deploying-the-elser-model which can easily timeout and leave you in a bad...

(I'm going to consider that #3252 fixed it until I hear otherwise, since this is the exact same issue.)

While this provides a new API to change the kwargs, the previous API (currently used by the Python Elasticsearch client) no longer works. The Requests docs contains [an example](https://requests.readthedocs.io/en/latest/user/advanced/#example-specific-ssl-version) where...

@sigmavirus24 I'm not sure I'm following the details, but I can certainly use `build_connection_pool_key_attributes` going forward (while keeping the old way for older versions of requests). That does mean a...

Hello! For what it's worth, those types make it difficult to use keyword arguments *and* `**kwargs`. Which is something that libraries building on top of aiohttp will need to do....

Thanks for answering! And yes we used `Dict[str, Any]` to get a release done, prior to that we did not have explicit typing: https://github.com/elastic/elastic-transport-python/commit/93a7d5efa2a46ba728b65e1309404640c25b6e27. This was fine because aiohttp did...