Quentin Pradet
Quentin Pradet
One issue about this is that it's going to change all line numbers by one, which will impair debugging because it makes it harder to read sync tracebacks as if...
@cdeler I can confirm now that keeping the line numbers is really important. Adding this comment at the end is an interesting idea! I'm not sure who's going to see...
Thanks for opening this issue! I'm a bit surprised here because my understanding is that unasync exists specifically so that you don't need functions like `await_or_return`. Instead `return await x`...
Right, this is needed when your API accepts both async and sync callables. Even though unasync is only a build dependency, I don't really mind adding utilities like that and...
Would `additional_replacements` be enough for your needs? https://unasync.readthedocs.io/en/latest/#usage
Why not, but I'd be interested in seeing your use case for this
Thanks for the detailed explanation! Yeah mypy wasn't as common when we started unasync. I would be happy to merge a pull request to that effect. @spyoungtech Note that to...
So yeah it looks like `unasync: remove` is enough! > The code in the gist is MIT licensed, so feel free to use it. MIT is good, but Apache 2...
Thanks for the feedback. I'm happy to include the feature, but don't have the reviewing cycles at the moment. Having someone to make CI pass (you?) and then someone to...
I still need to review two commits: [https://github.com/python-trio/unasync/pull/71/commits/600807e1f43fb4401f5f3af7984e1eee0f2f908f](https://github.com/python-trio/unasync/pull/71/commits/600807e1f43fb4401f5f3af7984e1eee0f2f908f) and [https://github.com/python-trio/unasync/pull/71/commits/4527a95fc65d388427cc41651c930368eb5ed4f4](https://github.com/python-trio/unasync/pull/71/commits/4527a95fc65d388427cc41651c930368eb5ed4f4). The rest looks good to me! (Sorry, it took me time to see this as I was on holidays and...