Quentin Pradet
Quentin Pradet
Thanks, that would be useful indeed :+1:
Ah you're right, that's much less important than I thought it was. I'll see if the timeout applies, and then close this issue if it does.
An issue with the timeout handling in urllib3 is that not timeout is applied when sending the actual request, see https://github.com/python-trio/urllib3/pull/57#discussion_r223247959.
We still need to update the docs but let's wait for #181 before working on it to avoid git conflicts.
Okay, the docs are now ready to be updated 👍
This would definitely be useful in our own test suite. 👍
Thanks! I need to look into this more but am currently on holidays. Please ping me in two weeks if you haven't heard from me. But yes I do intend...
@spyoungtech OK the master branch has all prerequisites now (Python 3.7+ with `tokenize_rt`) so we can integrate `unasync: remove` more deeply. If you're still interested, here's what's left to do:...
Oh, that makes sense. In that case I think it's fine to make that feature 3.8+ only. We should make sure to raise on Python 3.7 though (and test it)....
Thanks! As you can tell development has slowed down but I would be happy to review self-contained pull requests that fix those issue one at a time.