Pavel P

Results 137 comments of Pavel P

> This looks like a Asio issue. Could you please open an issue here: https://github.com/chriskohlhoff/asio/issues? What compiler flags are you using? It would help if you could come up with...

Yep, you are right, it's not exact. Please, ignore this one for now. Imo it should be refactored with STATIC_BMI instead

> Please, ignore this one for now. Imo it should be refactored with STATIC_BMI instead should be ok now.

linux-kernel fails with this error: ``` ../linux/lib/zstd/compress/../common/portability_macros.h:66:11: error: "STATIC_BMI2" is not defined, evaluates to 0 [-Werror=undef] 66 | && !STATIC_BMI2 ``` however, there is no `STATIC_BMI2` on portability_macros.h:66 line

> Try to rebase your PR on top of latest `dev` branch commit done

doesn't look like it, entire zstd repo only has a couple of mentions of it. ``` Code File Line Column #include "../common/portability_macros.h" zstd\lib\compress\zstd_cwksp.h 19 21 #include "portability_macros.h" zstd\lib\common\compiler.h 16 11...

> However, this only seems to be an issue when passing such variables by value. Local variables seem to be properly aligned even with GCC: that's exactly the issue I'm...