Pavel P

Results 104 comments of Pavel P

@powturbo please try to compile your code as c++, you'll see how badly riddled the code with all kinds of issues. In some cases, output param is declared as const...

VLC code is broken in 32bit mode. Will corrupt data. https://github.com/powturbo/TurboPFor-Integer-Compression/blob/06d6aad98b4be5471289f35d5d04fac4469cf6df/lib/include_/bitiobe.h#L4 (and all the other places that reference `__WORDSIZE` must be changed to 64) what a bugware.

these two files had mixed CR / CRLF line endings.

some refs: https://stackoverflow.com/a/74084728/468725

similar fix should be merged into zstd (plus all defines for `WIN32` from projects should be removed, but that's irrelevant). as a side note, what's the reason xxhash in lz4...

> `liblz4` proper only requires `XXH32`, which hasn't evolved. `zstd` stays more or less up to date with xxhash because it uses `XXH64`, is that correct? From xxhash the fastest...

Did you test with curl 8.8.0 to see if you get the same issue?

@bagder perhaps this can be configurable? Should be OFF by default, but can be enabled with options/flags at runtime? This way, it can be tested with updated OSes if it's...

> Sorry but I'm proposing it be removed entirely. #14794. FYI, any code that uses libcurl will fail with asan because of excessive threads created without internet connection. [Negative dns...