Pop Chunhapanya
Pop Chunhapanya
@vyzo The CI error log is not informative. Do you have any idea? ``` ... --- PASS: TestTopicPublishWithKeyInvalidParameters (0.08s) --- PASS: TestTopicPublishWithKeyInvalidParameters/nil_sign_private_key_should_error (0.00s) --- PASS: TestTopicPublishWithKeyInvalidParameters/empty_peer_ID_should_error (0.00s) === RUN FuzzAppendOrMergeRPC...
@vyzo I didn't get any error with FuzzAppendOrMergeRPC, did you? ``` $ go test -v -run FuzzAppendOrMergeRPC === RUN FuzzAppendOrMergeRPC --- PASS: FuzzAppendOrMergeRPC (0.00s) PASS ok github.com/libp2p/go-libp2p-pubsub 0.005s ```
done
@Stebalien @vyzo I think it's all done
should I squash the fix-up commits?
Why not v5.1? Is the version number 5.1 used?
> I do wonder however why there is no `GetENR` among the req/resp messages. Wouldn't that be useful to avoid the need for these updates to the Metadata? @cskiraly You...
I just did a research on peer count. https://notes.ethereum.org/@pop/peer-count-peerdas (it's still WIP) I have a concern on CUSTODY_REQUIREMENT=4 out of 128 subnets. It increases the number of peers you need...
> Following up with an additional question @mkalinin, is there a plan to introduce support for a lower top limit value below 2048 per validator, to replicate the existing mechanism...
> In fact, imposing an order means that requesters must verify the order and penalise out-of-order responses which ends up being extra code for no practical benefit. The requesters don't...