Pop Chunhapanya
Pop Chunhapanya
> However, I think using a slice to back the queue is problematic at many levels as it might leak space with a growing array, and also hang on to...
I'm not really sure if we need dfd81e80848e5ce4e64fbf30cfdaafb4dc56b9d3 or not. I guess adding a non-standard flag to `pb/trace.proto` would break some users of the tracers?
> Any progress other than that? I haven't implemented the second half. Does the first half looks good to you?
@vyzo I finished everything already. Sorry for the delay. I was in vacation and was a bit busy lately. Thank you for your patience.
The message ids from IDONTWANT can be very large, so hashing it before keeping it in memory quite makes sense. The same thing is already implemented in nim-libp2p https://github.com/vacp2p/nim-libp2p/pull/1090
Run `ip addr` to get the confirmation.
Got it. Thank you.
``` cat build/Testing/Temporary/LastTest.log Start testing: Oct 26 00:05 +07 ---------------------------------------------------------- 81/131 Testing: getsockname-linux 81/131 Test: getsockname-linux Command: "/usr/bin/sh" "-c" "../../target/debug/test_getsockname --libc-passing" Directory: /home/pop/repos/shadow/shadow/build/src/test/socket/getsockname "getsockname-linux" start time: Oct 26 00:05 +07...
@vyzo It's all done. Sorry for the delay.
@vyzo could you rerun the CI? thanks