Peter Plantinga

Results 76 comments of Peter Plantinga

> I just tried it, and it took 6 seconds by my count, which might be OK. However, it does turn out that the pre-commit check runs in its own...

> > > I just tried it, and it took 6 seconds by my count, which might be OK. However, it does turn out that the pre-commit check runs in...

A bit of news here that may be relevant: Astral.sh (who is behind `uv` and `ruff`) has been working since January on a static type checker for Python written in...

Hi @nouranali - thanks for your contribution. This is a step in the right direction, but I think there's more that's needed here. Just to warn you, the `core.py` and...

I don't have a lot of time to review this rn, but you can check it yourself by running a template, e.g. [`templates/speech_recognition/ASR`](https://github.com/speechbrain/speechbrain/tree/develop/templates/speech_recognition/ASR)

My only comments right now are: the `from_command_line_args()` method should be a `@classmethod`. And ideally the hparams file and yaml_overrides should become members of the RunOpts. I think the name...

I ran the checks and the linter failed. You can run it yourself, even automatically on every commit, following instructions here: https://github.com/speechbrain/speechbrain/blob/develop/docs/devtools.md

This used to touch only a few files but now touches over 500... did you run a different version of black on the whole repo?

If you install the `precommit` hook, the linters will run on all the files changed as part of the commit. The versions are in the file https://github.com/speechbrain/speechbrain/blob/develop/lint-requirements.txt

Is this issue closed with the merge of #2775 ?