Peter Plantinga
Peter Plantinga
What I am working on is not a current branch in eesen, so perhaps Stack overflow would have been a better place to bring this up. FWIW I solved the...
I merged develop and added a docstring, this is ready to review again.
Great PR, perhaps we can add some basic instructions for how to run one of the notebooks in Google Colab, something like this? https://saturncloud.io/blog/how-can-i-run-notebooks-of-a-github-project-in-google-colab/ Maybe in like a readme in...
> According to what I see, it seems there are some critical aspect. Firstly, when users click on the tutorial while navigating in the repository, Google Colab doesn't start, preventing...
We can probably even auto populate and check the links in the readme using a commit hook
I don't think this is quite the right approach because I don't think it allows for stopping/restarting which is part of the point of checkpointing. Instead, the checkpointer should store...
Tbh I think PEFT handles this perfectly, perhaps we should lift their code wholesale.
My opinion is we should just add it as a dependency, but I understand the objections to it. So instead we could just copy the parts of the code that...
I have used PEFT to apply Lora to an existing model and it was pretty straightforward to use. You just pass the model and it automatically replaces all relevant layers...
We could even import and use peft if the dependencies are light