Paul Pfeister
Paul Pfeister
So.... reply-to: @sdushantha Played around with schema versioning earlier, and ultimately decided against it. It sounded like a good idea at first, but in the end, it just seemed repetitive....
Personally indifferent. No reservations or preference either way. As long as normal pip usage isn't broken, then additional package manager support can only really be a plus. _~~As someone who...
So, I may be wrong on this, but it seems that poetry does not support dynamic versioning OOTB. The package version will either have to be manually updated each time,...
It also doesn't seem that poetry has support for dynamic loading of dependencies -- they would need to be explicitly listed in the pyproj. Thoughts there? Seems finicky on my...
Rebased onto master to fix conflict (some ~183 behind). Poetry rewritten in a way that actually works. Discovered that the current version of pyproject has some \~undesirable\~ install issues, namely...
(a couple minor doc updates included, i.e. pyproj readme logo and capitalization)
Dynamic versioning added but not yet enabled. Relies on named tags and applies throughout Sherlock, rather than pulling from src.
Fixed an import issue in entry point \_\_main\_\_. Note that `python3 sherlock/sherlock` is not likely to work anymore, as that would require a bunch of try catch imports. `python3 -m...
Most of my original comments seem to be resolved, which is nice. It was easier to just _rewrite_ it rather than adapt it for some reason. > Yes, poetry doesn't...
Well in that case, that's all I've got. _Probably_ good to merge... don't think anything else needs to be tweaked (except the github actions, which should probably be addressed separately)