Petr Penzin

Results 202 comments of Petr Penzin

For some reason I did not understand what you said right away. Let me confirm, but it makes sense to print the expected line endings (some people might be using...

Thank you for the demo. Could you please state what you are reporting, is that the shell running out of memory?

@yeguixin @YiWen-y thank you for the explanation. I believe we catch the attempt to go out of bounds, integer overflow is detected: ``` #7 0x00007ffff30a3f49 in Math::DefaultOverflowPolicy () at ~/ChakraCore/lib/Common/Common/MathUtil.cpp:37...

@rhuanjl I feel like we had a discussion about overflow handling before. From purely practical point of view, I feel it is OK for this kind of situations to get...

Thank you for the PR! The change itself looks good to me so far (though I'd like to hear from @rhuanjl), but there are a couple bits left. Can you...

I personally think it is reasonable. Since @rhuanjl is the mastermind behind that note in readme, I'd be interested to hear what he thinks about it. BTW, if your are...

``` $ cat 6772.js const v3 = new Int32Array(65537); const v4 = "replace".localeCompare(...v3); $ ch 6772.js ASSERTION 315203: (../lib/Runtime/Base/CallInfo.cpp, line 17) ArgList too large Failure: (count < Constants::UShortMaxValue - 1)...

ChakraCore uses VisualStudio directly on Windows, solution file is `Build\Chakra.Core.sln`. Also see [Building ChakraCore](https://github.com/chakra-core/ChakraCore#building-chakracore) in Readme. Enabling CMake builds on Windows is something of interest though.

`JsGetAndClearExceptionWithMetadata` should be able to help: https://github.com/chakra-core/ChakraCore/wiki/JsGetAndClearExceptionWithMetadata It returns a JavaScript object containing the source information. Let me know if this helps.

I've built this without sanitizer turned on and the example ran to completion (predictably doesn't fail in release mode). Probably needs more investigation.