Jarek Potiuk

Results 1588 comments of Jarek Potiuk

Rebsed and runnning the PR https://github.com/apache/airflow/actions/runs/7972889219

This looks good in principle (small and simple, yet powerful), but it would require a more complete documentation and examples in order to be mergable.

> * Implement a way to set a custom Auth class from the Connection UI / conn.extra_json. I'd say I am not so thrilled by the other option. and Certainly...

i just realised there is likely one big problem here - security. While we cannot prevent it completely for some kind of connections (this is why [Connection Editing user](https://airflow.apache.org/docs/apache-airflow/stable/security/security_model.html#capabilities-of-authenticated-ui-users) should...

Yes. Conceptually this is much better. I would need to take a closer look but first glance it looks good. Can you fix the last test, and I can take...

> I think this one is finally ready can you undraft it then ?

It's quite a big change. Generally speaking reviewing 700+ PRs will take weeks (if people have time). I wonder if there there is a way to split out parts of...

Usually what we do in such case - we take the bits of such PR, make new PR, review, merge, rebase (rinse and repeat).

> It’s a bit hard to split as all modifications are linked to each other. I was already happy I was able to pull it off imho ☺️ I know,...

cc: @jens-scheffler-bosch, @ashb @uranusjr @Taragolis @bolkedebruin -> this one needs someone who they know their ways around dill and serialization :). It's Python 3.11 only and we had already a...