Tim Popham comments

Results 5 comments of


                                            Tim Popham

As implemented, module-scoped constants may not work properly

The problem will pop up in generated code. The Cap'n Proto schema language admits circular imports, so your generated code will encounter circular imports like the following: ```capnp // file1.capnp...

As implemented, module-scoped constants may not work properly

Your struct-typed constants currently call `capnp.rawPointer` to yield a Pointer instance, so circular imports will work fine as currently implemented. If you intend to ever construct the actual struct types,...

As implemented, module-scoped constants may not work properly

I've added a hypothetical export of the module-scoped constant to #116. Running tests as written clobbered the hand coded additions, so I've altered gulp's `test:capnpc-js` task to stop the task...

Utf8 encoding goofs when a code unit from [0xD800, 0xDC00) isn't followed by a code unit from [0xDC00, 0xE000)

Here's my attempt if anybody finds it helpful: https://github.com/capnp-js/utf8/blob/master/src/encode.js.

Please consider using a different file extension.

In a thread of yours from a while back @jeffmo left a pretty detailed comment: https://github.com/facebook/flow/issues/1996#issuecomment-230919868. Doesn't the `.js.flow` extension meet your needs?