pomali

Results 11 comments of pomali

This looks like if `mytbpe_1` isn't reading environment variables and is trying to connect using sockets instead of network. But I don't remember, if I had some similar problem. I...

Yes, usecase here is generating two sets of objects with matching ids, so I can "join" them later. Eg. ``` interface School { locationId: number } interface Location { id:...

> Sorry for the delay in feedback. Could you please update this PR with the latest suggestions? No problem, sorry for mine delay. Updated.

There are some (maybe) controversial decisions, feel free to discuss them - choice of `aioapns` - it looks like only library with active development - supporting both `apns2` and `aioapns`...

I'm not sure what's missing, maybe someone should review it? And then there is code coverage check failing, but most of failing lines are comments, so I am not sure...

I ran it with an iOS simulator, but a second pair of eyes with a real device would be good idea

> > I ran it with an iOS simulator, but a second pair of eyes with a real device would be good idea > > I just tried this and...

> There is a possible bug with default argument pollution. Below test case can demonstrate the issue. I've also added a review comment about this. > Thanks for catching this,...

> I'm pretty sure I did when I tested it, but wouldn't that be handled by pip/piptools? @ssyberg it should be handled by pip, but it's optional dependency, so maybe...

I don't see any outstanding issues from my side.