matrix-nio icon indicating copy to clipboard operation
matrix-nio copied to clipboard

Incompatibility with Element and other SDKs due to MSC2746

Open abbbe opened this issue 2 years ago • 9 comments

Apparently nio is not compatible with Element, because of mismatch in the type of "version" field of m.call.* events. I have asked around at #matrix-specs and was told that Element (and allegedly all other SDKs besides nio) has merged MSC2746.

Any thoughts on this?

abbbe avatar Jan 25 '23 11:01 abbbe

PS. I did submit a PR about this couple days back, but closed it after I realised it was not any good, see discussion with HarHarLinks there.

abbbe avatar Jan 25 '23 11:01 abbbe

Example works with Element for me, only tested with unencrypted tx/rx from room.

mrx23dot avatar Feb 09 '23 22:02 mrx23dot

Do you mean the original example? What version of Element on what platform have you tested it with?

abbbe avatar Feb 10 '23 07:02 abbbe

First example from: https://matrix-nio.readthedocs.io/en/latest/examples.html

works from Windows/linux, it's picky about creadential format

srv = "https://matrix.org"
roomID = "!xx:matrix.org" 
usr = "@xx:matrix.org"
pwd = "xx"

mrx23dot avatar Feb 10 '23 10:02 mrx23dot

My bug report / PR is specific to the way matrix-nio handles m.call.* messages, which are generated only during video/audio calls. Does the example you refer place / receive any calls? Could you please give an exact link to the example you refer to?

abbbe avatar Feb 10 '23 10:02 abbbe

My bad, I only tried it with text based.

mrx23dot avatar Feb 10 '23 11:02 mrx23dot

I also encountered this problem after attaching a callback to a CallInviteEvent and not catching any events. The issue is that nio tags the events as bad events, due to a type mismatch of the version parameter. Current version of Matrix Element uses string type for the version parameter. According to MSC2746 the version parameter should treat numeric values as if they had version == "1".

specifically here the schema only accepts numeric types, producing a bad event.

murlock1000 avatar Mar 15 '23 19:03 murlock1000

@abbbe did you find a solution for this?

Sohojoe avatar May 20 '23 21:05 Sohojoe

I haven't looked into this particular MSC/incompatibilities in our current behavior. If there's still a PR to be made, it'd absolutely be welcome!

PaarthShah avatar Jun 26 '23 18:06 PaarthShah