Brennan Kinney

> In recent days of this project, all of them are devDependencies, not critical dependencies, they do not affect the use of end-users and core features of this action. Awesome...

Nom 4.0 release has [this article](http://unhandledexpression.com/general/2018/05/14/nom-4-0-faster-safer-simpler-parsers.html) with some http parsing benchmark results graphed at the end. `combine` has the lowest performance, although it's close to `nom` naive results, the optimized...

Nice work! :D You got it pretty close! Will it be PR'd to the benchmarks repo as combine-optimized?

Just spent past day with my alpine docker image, turned out build issues were with imagemin dependencies(cwebp, pngquant(this ones binary worked fine), mozjpeg). If I use local packages my image...

@ljharb it was originally in the `devDependencies` prior to 1.0.0 it seems. But even then I don't see any usage of it. `optionalDependencies` is meant to be used for allowing...

Should I add [two new inputs here](https://github.com/nwtgck/actions-netlify/blob/develop/src/inputs.ts)? One for substitute PR number `context.issue.number` (`inputs.targetPR()`), and another for this PR `getSHA()` method?: ```ts function getSHA(): string { return inputs.targetSHA() ?? context.payload.pull_request?.head.sha...

? I want to be able to say here is the pull request number, treat the action as if it was running from that PR or that commit. This would...

@nwtgck Hello, consider this: https://github.com/nwtgck/actions-netlify/blob/4ad40dcf68dab431d2fc0ba3a0e01e811c034a43/src/main.ts#L48 ```diff - const deployRef = context.payload.pull_request?.head.sha ?? context.sha + const deployRef = context.payload.pull_request?.head.sha ?? github.event.workflow_run.head_sha ?? context.sha ``` I'm unsure what the `context.*` equivalent is,...

For comment on pull request, your code just checks for number. This one can only be better supported by user providing `issue.number` to the action inputs. If that is not...

Made two PRs: - [README docs for troubleshooting](https://github.com/nwtgck/actions-netlify/pull/550) with workarounds added to restore features. - [Possible `workflow_run` commit fix](https://github.com/nwtgck/actions-netlify/pull/549), if this works only the PR comments is unsupported.