Mike Pokraka

Results 183 comments of Mike Pokraka

Just in case anyone is wondering, I haven't forgotten. Time constrained by projects until the end of June. If anyone wants to work on it before then feel free, else...

How old was this repo? These were never supported in abapGit AFAIK. Once upon a time there was some incomplete work in SAPlink to get PDTS/WS working. @christianguenter2 had a...

Hi @chrismills, the XML was very useful. The key clue was in: `` So it was serialised as a standard SOBJ object, I'll look into this a little further.

OK it was done using the deprecated SOBJ plugin https://github.com/abapGit/abapGit-Plugins You can probably use the plugin if you're importing on the same SAP version as you exported, but generally it's...

It's been a good few months since this issue and major git hosts and many repos have switched to `main`, so could we default to that now? Also, the behaviour...

Not in favour of this one. Firstly, although I broadly follow the pattern, it is often sensible to combine two of the stages or even all of them, e.g. `cl_abap_unit_assert=>assert_initial(...

Just my opinion, but I find the relational operators far shorter and readable, as is obvious from the list above. Yes, they're not common in other languages but are not...

I am not sure why parameters should be irrelevant. That implies that these two statements should be treated differently: ```ABAP result = some_method( me->value ). result = me->value. ``` They...

Oh dear, looks like we submitted PRs in parallel 😆 Ah well, let the stylists pick one

I don't know if such a check exists, but we should only allow boolean types with implied booleans (or whatever they're called). e.g. `IF is_loaded( ).` will evaluate to `true`...