SAP
False Positive: Omit self-reference when calling instance method
Check Name Y_CHECK_SELF_REFERENCE
Actual Behavior check reacts to usage of instance attributes when calling an instance method
DATA(sum) = aggregate_values( me->values ).
Expected Behavior Parameters should be irrelevant to the check
The Clean ABAP discourages the use of self-reference. However, it is unclear if the rule is valid for instance methods and instance attributes, or methods only. In my understanding, we should avoid self-reference if it is not needed.
In your example, is there any local variable named values that could cause conflict?
I am not sure why parameters should be irrelevant. That implies that these two statements should be treated differently:
result = some_method( me->value ).
result = me->value.
They both should omit me-> unless there is a scope conflict.
I interpreted Clean ABAP that its superfluous for method calls as they can only ever be on the instance, however there is no mention of attributes/variables. IMO it would be better to have it explicitly mention that we want to use an attribute of the class.
I assume the test would still mark my example as an error even when I explicitly want to use an attribute instead of a local variable with the same name?
I assume the test would still mark my example as an error even when I explicitly want to use an attribute instead of a local variable with the same name?
No, it wouldn't. The Check should identify that you have a local variable with the same name (scope conflict) and exempt it automatically.
Oh dear, looks like we submitted PRs in parallel 😆 Ah well, let the stylists pick one
No, it wouldn't. The Check should identify that you have a local variable with the same name (scope conflict) and exempt it automatically.
I have been updating the unit test based on this thread, and I figured out the instance attribute is out of the Check's scope. If the Clean ABAP team accepts one of our pull requests, I will update the Check accordingly.