Pokey Rule

Results 577 comments of Pokey Rule

update from meet-up: - we do want tests - @AndreasArvidsson will keep this for now, but if time doesn't allow, @pokey will steal this PR in a week

There is a spoken form inconsistency here: in community, the spoken form for snippet insertion is "snip", but the default spoken form for snippet insertion in Cursorless is "snippet". So...

Ok I added tests, but: - See caveat in https://github.com/talonhub/community/pull/1315/files#r1471234714 - It relies on user having `"code"` snippet (code block). That's shipped in community, so should be fine, but we...

update from meet-up: - run one last local test and then ship this alongside https://github.com/talonhub/community/pull/1315

Yeah it got caught in that weird windows CI issue; totally unrelated to this PR. Just updated the branch so it gets the fix. Should pass and merge shortly

is there a reason this is still marked as draft? Looks like there's some unchecked boxes in description too

Got it. So would it make sense to knock those out now that we're aligned on the high-level direction or did you want me to take a look first?

Ok I've now fully reviewed this PR. I made a bunch of changes. I think what remains are: - [x] Review [my changes](https://github.com/cursorless-dev/cursorless/pull/2457/files/39d2309155731c71939f3c2d25750168f734564e..db97b693a266e274de02994aae80641338d281f5) to make sure you're happy - [x]...

I wonder if we should make iteration scope be "line". I think being able to say "first string" / "last string" will be really useful

Update from meet-up: - Go for option 1 - Had several ideas for avoiding running the dirs that are not actually language id's and are just for importing: - Use...