Patrick Ohly
Patrick Ohly
After a "resource exhausted" error and selecting a different node, the original provisioner instance keeps getting updates and/or continues to work on a PVC that it should ignore: ``` I0902...
capacity.go currently uses `Update` to change the capacity value. It might be more efficient to use `Patch`: - write a benchmark - compare both approaches
When deploying external-provisioner alongside the CSI driver on each node, there is one problem: if the scheduler picks a node which has no driver instance, then the volume is stuck...
In the following sequence of events a volume can leak: - external-provisioner issues a CreateVolume call for a PVC - external-provisioner is stopped before it creates the PV - the...
As discussed in https://github.com/kubernetes-csi/external-provisioner/pull/612#discussion_r616191330, the usage of `GenerateAccessibilityRequirements` in the following code could be improved: https://github.com/pohly/external-provisioner/blob/f262e0f93ce2c172ac22f54978bbb9aff7f59d21/pkg/controller/controller.go#L1296-L1320 It works because the function is expected to only fail when the storage class...
`go vet` warns about ignoring the cancel function returned by context.WithCancel(): ``` func ExampleStreamDirector() { director = func(ctx context.Context, fullMethodName string) (context.Context, *grpc.ClientConn, error) { // Make sure we never...
The ExampleStreamDirector (in examples_test.go) my run: ``` return nil, nil, grpc.Errorf(codes.Unimplemented, "Unknown method") ``` handler.go then uses the outgoingCtx without first checking for an error: ``` outgoingCtx, backendConn, err :=...
The current gRPC seems to add a "content-type" header automatically, causing the tests to fail with: --- FAIL: TestProxyHappySuite/TestPingCarriesServerHeadersAndTrailers (0.00s) handler_test.go:138: Error Trace: handler_test.go:138 Error: "map[test-client-header:[I like turtles.] content-type:[application/grpc]]" should...
Adding new methods to the gRPC interfaces is backwards-compatible at the gRPC level and thus the major version of the CSI spec repo is not incremented. However, the way how...
Kubernetes 1.19 will be the first release which actually does something with the CSI GetCapacity call: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1472-storage-capacity-tracking Because the Kubernetes scheduler cannot communicate directly with the CSI driver, we are...