Lennart Poettering
Lennart Poettering
There's not much actionable about this. At least privide a "resolvectl status" output, please...
Please do the following: ```console systemctl edit systemd-resolved.service ``` then, in the editor that opens write this: ``` [Service] Environment=SYSTEMD_LOG_LEVEL=debug ``` Then save and exit. Then do 'systemctl restart systemd-resolved`,...
> I have now fixed all the review comments, and added a basic integration test. btw, please click on "Resolve conversation" for all review issues you addressed.
i did half a review round now, but i noticed there were a bunch of unaddressed items. Please fix those first, and make sure to mark them as resolved as...
we are getting closer
please fix the dbus error thing, otherwise looks good
CI is unhappy
lgtm now, but CI doesn't agree with me, apparently ;-)
still lgtm, and if CI succeeds, ready to merge, but please squash your commits, i.e. we want perfect bisectability, and "perfect" commits. i.e. every commit should reflect a logical step,...
> This seems to implement a reduced job management implementation - given all such things sooner or later get a requirements to do ordering/dependencies, wouldn't it be better to immediately...