Lennart Poettering comments

Results 1508 comments of


                                            Lennart Poettering

systemctl/coredumpctl: add support for --root and --image options

lgtm

systemctl/coredumpctl: add support for --root and --image options

first commit looks good. second one not yet. (also, if you add --root=, might be easy to just add --image= as well at the same time)

systemctl/coredumpctl: add support for --root and --image options

Also needs a rebase, the internal dissect apis have changed since this PR was pushed.

systemctl/coredumpctl: add support for --root and --image options

I cherry picked the first commit already into git main, I figured it's indepdendent enough of the other two and no reason to delay merging for that.

systemctl/coredumpctl: add support for --root and --image options

some post merge review issues...

shared/logs-show: add new --output= format "short-delta"

looks good, just went a little bit overboard with the const there. ;-)

core: introduce env variable that makes user manager to not enumerate devices

This is a hack I am sure. It#s OK as env var I guess, but should not be advertised as feature. People should be able to rely on these unit...

core: introduce env variable that makes user manager to not enumerate devices

So, the unit types already have a .supported() vtable function, that for example disables swap and devices in containers and such. I am pretty sure we should hook this new...

core: introduce env variable that makes user manager to not enumerate devices

I'd really implement this generically in unit_type_supported(). i.e. add something like this there: ```c bool unit_type_supported(UnitType t) { static int8_t cache[_UNIT_TYPE_MAX] = {}; /* -1: disabled, 1: enabled: 0: don't...

core: introduce env variable that makes user manager to not enumerate devices

I consider this a debugging feature, a hacker feature. I think for features like that it's really OK if you can shoot yourself in the foot. I'd see this as...