Lennart Poettering comments

Results 1507 comments of


                                            Lennart Poettering

Possible `systemctl` symlink-related issue with `--root=` and bind mounts

/cc @keszybz

repart: Add --verity switch to control verity formatting

Hmm, I think we should still read the verity partition info, so that we can take it into account for space allocation, positioning and so on. But then not actually...

test-mountpoint-util: support running on a mount namespace with another mount on /proc

Hmm, looking at this again, isn't this actually just a matter of always storing info about the last entry for any given path in /proc/self/mountinfo, instead of the first, like...

core: do not create symlink to private directory if parent already exists

hmm, the explanation i asked for should probably end up in comments in the code, and not here, actually ;-)

homed: cannot login after sleep

pam_systemd_home() says all is good. Not sure what is denying your login, but it's not homed. pam_securetty() is legacy garbage. This should not be in any PAM stack. if it...

sd-device: introduce sd_device_get_child_first() and _next()

lgtm, just wondering about the foreach/name macro, see comments above

repart: Add support for generating verity sig partitions

Now you made me think: for the verity stuff we use PEM certs, for the pcr stuff we use PEM pubkeys only. For SecureBoot stuff we need certs if iirc,...

repart: Add support for generating verity sig partitions

lgtm, just some minor nitpicks, see above.

udev: support by-path devlink for multipath nvme block devices

lgtm

tmpfiles: suppressing `uninitialized /etc` warnings on offline systems

maybe just downgrade them to LOG_DEBUG if `--root=` is set? Keep them at LOG_WARNING if `--root=` is not set?