Panu Lahtinen
Panu Lahtinen
I'll see what I can do for testing. It's not easy, because the file handler is never used in the tests.
I've now added two tests that hopefully show that the storing and reusing of common items between the FCI L1c segments work.
Anything in the list shown [here](https://github.com/pytroll/satpy/blob/main/satpy/etc/readers/fci_l1c_nc.yaml#L23) that don't end in the strings listed in `NONSHAREABLE_VARIABLE_ENDINGS` can be shared between the segments. Note that the `{chan_name}` is replaced with the 16...
> In addition, could more implementation be in `netcdf_utils` so it can be used by other readers where relevant? I think so. As I said in another comment above this...
pre-commit.ci autofix
pre-commit.ci run
pre-commit.ci autofix
I did some format testing. Saving to PNG with `fill_value=0` using Satpy and reading the image back with `rasterio`, we can see that `nodatavals` are `(None, None, None)`. I think...
I approve
The coverage report says 14 lines miss coverage. Haven't looked too closely, but likely something I don't have much experience with. The naming change with associated aliases and deprecation warnings...