pmoleri

Results 15 comments of pmoleri

Hi, I think this thread has revolted on Typescript when it's not part of the issue at all, only that is not being helpful restricting the type, so it allowed...

I think the code shouldn't be using `path` at all, it's only using it to join dropbox paths instead of local paths. I would use a simple string join: `var...

I had the same issue when running the tests on Windows 10 [email protected]. It's very annoying to contribute when there are unrelated failing tests. I came across this interesting stackoverflow...

Hi @yuri-apanasik I think that the correct code should be analogous to this patch: https://github.com/ReactiveX/rxjs/pull/7444/files#diff-64da125812f733a97ec0d18250db7664156743309052001c7a5eeaf2109a822b With `action.id` taking precedence and `_scheduled` only cleaned when it's its case. > Hi @benlesh,...

@yuri-apanasik > global logic with both patches (your or mine) will be the same The code communicates different intents, although, in practice it might end up being equivalent because of...

Hi @aheckmann , this is an important PR, otherwise the use of `.stream()` is unreliable. I guess the PR would have to get rebased, if that's done, would you merge...

Also, this cast has no sense: ![image](https://github.com/IgniteUI/igniteui-angular/assets/12942794/f9ae4230-8034-478e-9aa8-196085122096) Also noticing this possible inconsistency: ![image](https://github.com/IgniteUI/igniteui-angular/assets/12942794/50a97a47-e0f6-4283-9356-eb7f9efdfef4) I don't see any reason why `set value` and `writeValue` should do different things. They should probably...

Perhaps we should report his as a different bug. But using `selection='multi'` the calendar doesn't react to removing dates from the input array: https://stackblitz.com/edit/s81ez8-yryk3e?file=src%2Fapp%2Fcalendar-sample-5%2Fcalendar-sample-5.component.html,src%2Fapp%2Fcalendar-sample-5%2Fcalendar-sample-5.component.ts

Re-opening as this is also reproduce-able using "range" mode. "multi" mode already has a safe-guard by comparing the new and old dates. But it has a different issue, it's not...

Given that the documentation states: > NOTE: If a package being installed through git contains a prepare script, its dependencies and devDependencies will be installed, and the prepare script will...