Philip Mocz

Thanks Kelle!

There is possibly a serious issue in [`do_predictive_mixing()`](https://github.com/MESAHub/mesa/blob/main/star/private/predictive_mix.f90#L209) in the stopping criterion for its [`search_loop`](https://github.com/MESAHub/mesa/blob/main/star/private/predictive_mix.f90#L363). Note that in this loop we are increasing `k_bot_mz = k_bot_mz + 1` when `outward`=false,...

> > What should the search_loop return in this case? set `k_bot_mz = s%nz-1` and exit the search loop? > > That seems like it could work! Would it also...

Sounds like we should make TDC and predictive mixing a run mode that is not allowed, as @Debraheem has nicely done! @rhdtownsend what are your thoughts on how to fix...

I was able to reproduce this issue. You can get good results with `use_Ledoux_criterion = .true.` if you also set `num_cells_for_smooth_gradL_composition_term=0` (the default value is 3; changing this parameter should...

What is the status of this PR? Is it nearly ready to go? I can help fix conflicts with main (a lot of it is due to removing unused variables...

> I think it's worth fixing the conflicts with `main` because this is a change we should implement at some point. > > My [previous comment](https://github.com/MESAHub/mesa/pull/552#issuecomment-2156782641) is as far as...

I tried out the code. If I set V0 = 0, it gives me the correct result that z velocity is 0. If I set it to 2 like you...

Thank you for the interest in my blog posts, and for catching the missing minus signs! I updated the text to reflect it. For periodic boundary conditions, the easiest way...

You see this error if you prematurely close the figure, which is not a problem. If you do not see any figure pop up, then this may be an issue...