react-xr icon indicating copy to clipboard operation
react-xr copied to clipboard

Give a better message when not on HTTPS

Open richardanaya opened this issue 1 year ago • 1 comments

This might be confusing to new users who don't know they need to run their dev servers on HTTPS.

richardanaya avatar Oct 22 '23 21:10 richardanaya

I believe we already discern HTTPS, but would be good to link to instructions in any case.

https://github.com/pmndrs/react-xr/blob/4d23eb88daa5ae484de05fa157cdc7fe366c2e47/src/XR.tsx#L363-L365

https://github.com/pmndrs/react-xr/blob/4d23eb88daa5ae484de05fa157cdc7fe366c2e47/src/XR.tsx#L327-L345

CodyJasonBennett avatar Oct 29 '23 13:10 CodyJasonBennett

imo this shouldn't be part of the implementation but rather be mentioned in the tutorials on the documentation

bbohlender avatar Jul 17 '24 07:07 bbohlender

documentation has now explanation about development setup mentioning Https and a pitfalls section mentioning the need of Httüs

bbohlender avatar Aug 01 '24 15:08 bbohlender