Plamen Mishev

If there are no other changes you'd like me to make, do you want me to do a rebase onto main?

I am getting `knp_paginator` from the container. You could see more context here, where I get the error: https://github.com/sineflow/ElasticsearchBundle/blob/2019-10-22-knp-fix/Tests/Functional/Finder/Adapter/KnpPaginatorAdapterTest.php#L142 But the point is, that here https://github.com/KnpLabs/knp-components/blob/master/src/Knp/Component/Pager/Paginator.php#L64 you basically rely to...

I do not, but I imagine if I tried to use the paginator from a Console Command, there wouldn't be a Request either. Plus, I wouldn't dare to assume I...

I suppose you are referring to https://github.com/KnpLabs/KnpPaginatorBundle/issues/563 ? Yes, if I use the `$kernel->getContainer()->get('request_stack')->push(new Request());` hack, I can get my test working, but I don't think that's the point. But...

I had the same problem today, but the issue was not specific to flameshot. It also happened for the default ubuntu screenshot app. In my case I believe the problem...

Sorry, did it from `master` in a hurry. Hope it's all right

Have you considered merging this fix?

Just checking in to see if you need anything more fixed in this PR?

Did the rebase. As far as the `@param` are concerned, we had a discussion about those above. I did some research then and didn't find any consensus on what's the...

So, instead of this: ``` * @param object $node * @param array $options = [ * 'includeNode' => true, // Whether to include the node itself * ] * *...