Pierre-Marie Dartus

Results 50 comments of Pierre-Marie Dartus

For the record, there is still a lot of work that happens first to handle properly classic scripts: https://github.com/jsdom/jsdom/issues/2413.

Could you share a sample repository showcasing this bug?

> Under what circumstances are tests skipped in the coverage table (if any)? This package is a simple wrapper around jest ([code](https://github.com/salesforce/sfdx-lwc-jest/blob/master/src/utils/test-runner.js#L70-L93)). `@salesforce/sfdx-lwc-jest` delegates all the coverage processing to jest,...

We can definitely add this to the `CHANGELOG.md`. @trevor-bliss What do you think about also tagging the version on NPM, the same way we do on LWC?

Between version `0.9.2` and `0.11.0` we did bump [jest from 25 to 26](https://github.com/salesforce/sfdx-lwc-jest/commit/10137744d07a86bfa8b2eeb85cab82177a84acf9). Between the 2 versions, jsdom [was bump to version 16](https://github.com/facebook/jest/releases/tag/v26.0.0). We haven't seen any breakage internally at...

I am unfortunately not able to reproduce the issue with the content you shared. Could you please create a small SFDX project with clear reproduction steps?

I spent some time extracting a minimal reproduction step out of the repo you shared. The minimal repro can be found [here](https://github.com/pmdartus/sfdx-lwc-jest-update-bug) ([update commit](https://github.com/pmdartus/sfdx-lwc-jest-update-bug/commit/1bd9ede27303e4682cbd72e31176a3213148e765)). It appears that between versions `0.9.2`...

You are right, I think it will be really elegant to do that at the project level.

I am not familiar with how flow works, so bear with me. As far as I understand the meta XML file, your component looks like this: ```js import { LightningElement...

Yes, I will do that soon. I was just too excited to share those numbers.