Pablo Mazzini

Results 71 comments of Pablo Mazzini

Related PRs #105, #106 and #107.

@kperanovic Thanks for working on this!

Thanks for the info. How do we know if it continues to work? Are you suggesting to setup a CI with `llvm-goc`? Are you willing to do this?

No, this is still trying to parse all the options with a fallback in case the parsing fails. The idea of lazy parsing is not parsing the options at all,...

Moving to lazy parsing is not a trivial change though.

I think the NBP URL should come from a separate plugin.

@jparise Any chance of merging this?

> I wonder if server and client should be separate packages Server and client are both different packages now. Several helper functions were added since.

Looking back at this, should it have been `NewRenewFromAck` instead of `NewRenewFromOffer`?

> There's a problem with that, the server may decide to drop the client IP from the ACK response (see ciaddr [here](https://www.rfc-editor.org/rfc/rfc2131#section-4.3.1)), which means that a purely ACK-based solution would...