Pierre-Marie Padiou

Results 80 comments of Pierre-Marie Padiou

I'm interested in your opinion on `obj.getClass.getPrettySimpleName` vs `obj.prettyClassName`.

Note to self: need to check after #2340 is deployed on our node.

> I don't think these two commits should be done in the same PR Agreed, I got a bit carried away and kept experimenting. > I'm not sure the second...

> I think it should be documented clearly, probably a new document in the docs folder. Agree! > maybe the new configuration parameter should just be a boolean stop-node-on-outdated-commitment-after-restart =...

>> I don't think these two commits should be done in the same PR, > Agreed, I got a bit carried away and kept experimenting. On 2nd thought, I kept...

So, while testing this PR I realized that in an "outdated commitment" scenario where we are on the up-to-date side, we always react by force-closing the channel immediately, not giving...

> Don't forget to also add an entry in the release notes for this, it's really newsworthy ;) Done with 9957a83. I could put the full doc, but I don't...

Rebased on top of #2036, the diff is now much smaller.

Rebased on top of #2037. This PR is not immediately useful due to how other implementations react when they detect that the peer is using an outdated commitment: they immediately...

This branch is currently running on our production node: the goal is to gather information on the current state of the network and find out the best way to implement...