eclair icon indicating copy to clipboard operation
eclair copied to clipboard

Published 20 hours ago • verified publisher icon ACINQ

[WIP] Peer rate-limiting

Open pm47 opened this issue 6 years ago • 3 comments

pm47 avatar Nov 15 '18 12:11 pm47

Any plans to merge this? Just be really good to get the metrics bit merged as was wanting to add a lot more. So understand what is actually going on in the node and what it is spending time doing.

n1bor avatar Jan 01 '19 22:01 n1bor

This branch is currently running on our production node: the goal is to gather information on the current state of the network and find out the best way to implement peer rate limiting, but the actual work hasn't started yet.

pm47 avatar Jan 02 '19 10:01 pm47

Was just wanting to have the codehale metrics commit merged - rather than the rate limiting bit. Then I can add a number of PR's for: Timing round some of the db calls. Rate of events on the EventBus Cached gauges on number of nodes/channels etc.. Return some of the cached guages in getinfo API call.

Also did you see you can use annotations? https://metrics.dropwizard.io/4.0.0/apidocs/com/codahale/metrics/annotation/Gauge.html

n1bor avatar Jan 02 '19 11:01 n1bor