Victor M. Alvarez

icon indicating a website link www.virustotal.com icon indicating an email [email protected]

icon company Google icon location Bilbao, Spain icon location Senior Staff Software Engineer at @VirusTotal @google. Author of virustotal.github.io/yara-x

Results 206 comments of Victor M. Alvarez

PE signature validation doesn't detect malware signed with sigthief

The previous comment went unnoticed to me, so I didn't respond earlier, but the answer from @HoundThe is exactly what I meant.

RuntimeError: Event loop is closed in multiprocessing enviroments (celery).

I don't quite understand the issue. Is that the event loop used by `vt-py` is being closed at some other place?

RuntimeError: Event loop is closed in multiprocessing enviroments (celery).

I'm not sure about that. When you are using `vt-py` in async mode (i.e: using exclusively async functions from the library) the event loop is something external to the library,...

RuntimeError: Event loop is closed in multiprocessing enviroments (celery).

I'm ok with adding protective measures if that helps, but I don't know what type of protective measures we can add. Do you have some specific measure in mind?

pehash function integration in pe module

Interesting. The downside is that we'll end up having different implementations, and that will be very confusing for people already familiar with totalhash/Viper's one. It's a shame they didn't get...

Add math.length()

I find a bit weird that this is included in the `math` module. Maybe it's time for a `string` module?

Better error reporting.

I'm experiencing the same issue with error messages. The message always seems to report the top level rule, even if part of the rule is matched correctly and the actual...

Extend dotnet module

Looks good to me. The only thing I miss is adding `.. versionadded:: 4.3.0` to the new fields in the documentation.

[Yara 4.5.0][Build error] --- pread64 not found on Alpine Linux

Should be fixed in 833a580430abe0fbc9bc17a21fb95bf36dacf367

save() results in "internal error : 58"

With `StringIO` the error is expected because `StringIO` shouldn't be used with binary data. However, with `BytesIO` it should work, and there's even a test case for that. Can you...