Victor M. Alvarez comments

Results 206 comments of


                                            Victor M. Alvarez

syntax: accept `{,n}` as an equivalent to `{0,n}`

That was quick! Thank you so much.

Test Failure - test-pe: tests/test-pe.c:292: rule does not match contents of'tests/data/

Yes, it looks related to LibreSSL. The first step is trying to minify the test case, if we are lucky the problem is one specific condition within the rule. For...

modules/pe: make resources sanity check stricter

My concern with this change is that it doesn't tackle any real issue with files that are corrupt but have a low enough `NumberOfNamedEntries` and `NumberOfIdEntries` that passes the check....

[Yara 4.5.0][Build error] --- pread64 not found on Alpine Linux

Yes, I think it's time for a new release.

linux.c: don't use pread64

This was explicitely changed in #2005. @vthib, could you take a look a this PR?

linux.c: don't use pread64

I prefer not having to deal with a `config.h` file, and go with @vthib's proposal.

linux.c: don't use pread64

Fixed in 833a580430abe0fbc9bc17a21fb95bf36dacf367

make check error: invalid field name "type"

I was pulling my hair trying to reproduce the issue, without success. I don't know how something like that would happen. What if you try recompiling again? Maybe the issue...

YARA conditional imports/features

The problem I see here is that if your clients don't update to a newer version of YARA that implements this feature, you will be in the same position anyways....

Check for impossible conditions when using uint() operators.

I think @wxsBSD is right. Why `uint32(0) == 0xABCD` should be incorrect? This is not really an impossible condition. `0xABCD` is the same as `0x0000ABCD`, and most people will expect...