Burak Arslan comments

Results 131 comments of


                                            Burak Arslan

In Python 3.4, ByteArray serialization yields and consumes wrong types

:) thanks

MessagePackRpc protocol does not handle mmap instances in ctx.in_string

Linux page size being a hardcoded #define of 4k, did you notice a difference between 4k and 100k? I'd prefer that value to be as low as possible.

MessagePackRpc protocol does not handle mmap instances in ctx.in_string

I'm also actually very nervous dealing with mmaps inside twisted's reactor thread. It's there on the sole assumption that twisted guys dug deep enough to know that it's OK to...

MessagePackRpc protocol does not handle mmap instances in ctx.in_string

ok, thanks for letting me know. in the mean time, could please clean the issue page? do you realize you're broadcasting all of your contact details to the internets?

MessagePackRpc protocol does not handle mmap instances in ctx.in_string

with mmap you don't need a feed api -- that's exactly what mmap is for. it doesn't read anything initially and brings data from fs as you read it. And...

MessagePackRpc protocol does not handle mmap instances in ctx.in_string

ah sorry, you're saying that msgpack's implementation reads everything at one go anyway. ok, there's not going to be a list of mmap()s, so i'll adapt your patch and commit...

Indentation (i.e. LOG_SCOPE_F) is not thread-safe

Sorry for resurrecting an old thread but it could be useful to add `LOG_GSCOPE_F` (for global scope), `LOG_TSCOPE_F` (for thread scope), both of which would in turn call the `LOG_CSCOPE_F`...

Support MessagePack for Keys & Values (just a comparison function)

Why doesn't ``memcmp()`` work? What exactly do you need?

Fix tests for python 3.12 and sqlalchemy >=2

ok to test

Fix tests for python 3.12 and sqlalchemy >=2

Thanks for the PR! If something is not obvious, I'm happy to answer questions regarding failures.