Pierce Lopez

Results 269 comments of Pierce Lopez

... I think @mreiferson thought you might be interested in trying to write this "modular stats export" architecture. And see also an analogous issue for nsqadmin: #732

I don't think we would want separate repositories or separate plugin libraries/files, I think we would prefer these "modules" to be in this repo and compiled into nsqd / nsqadmin....

glog isn't strictly required in order for logs to be rotated. There are a few different systems that collect stdout/stderr from processes/services and manage the writing of log files. This...

I do not object to a few more logging features, or to glog in particular.

For windows support, I'd personally suggest ripping out the windows service hooks that are in nsqd/nsqlookupd, and tell people to use [winsw](https://github.com/kohsuke/winsw/) to wrap them for windows. It looks like...

Not arguing, just bringing up the datapoint to be considered. To be clear, it seems that #817 is in fact caused by the windows service hooks in nsqd and nsqlookupd,...

Also, honest question, how do _you_ manage nsqd / nsqlookupd logs on windows?

If nsqd/nsqlookupd/... were to use a more sophisticated logging library, like glog or logrus, it would need to be made to integrate nicely with nsqd/nsqlookupd/... command-line flags and config files,...

With go 1.4 I was able to put the nsq repo wherever I wanted, and make a symlink to it in the right place in GOPATH. With go 1.5 they...

go upstream would prefer that you check it out into `$GOPATH/src/github.com/nsqio/nsq` the first time, it's odd but doesn't require any copies