Pierce Lopez

Results 269 comments of Pierce Lopez

Eh, I think it's a bit early to use Plugin

I just re-added a comment about this approach. But you should probably not actually work on it if @mreiferson is against this. I am sorry if I've led you on...

I can see a path forward to plugins, from this model. nsqd would need to look in a directory (probably from a flag option) for plugin files named e.g. `name.so`....

I have a couple minor stylistic quibbles, but I like the structure. @mreiferson are you somewhat convinced yet ;)

I'll take another look real soon, was just a bit busy at work ...

@mreiferson I think I can clean this up a bit, in terms of API, before the next release, and I think I can work on transitioning this to use go...

actually, everyone just wait for a few days, I'll open another PR (which includes and adds to this one)

It's very reasonable to wonder what is going on with this PR. I happen to be on a vacation overseas, so you won't see any update from me before the...

Agreed, but I'd be somewhat open to a datadog output module, if we had a more modular/pluggable stats interface and e.g. an influxdb output module as well. So, if it...

I should clarify that there is not yet a "contrib" architecture. What I meant was just a modular architecture for stats exporting in which (eventually) one module could be less...